chore: sort out signal handling (#506)
This commit is contained in:
parent
f31ef598bc
commit
0b74cdaaf8
2 changed files with 15 additions and 2 deletions
|
|
@ -98,7 +98,11 @@ class IsolatedContextFactory extends BaseContextFactory {
|
|||
|
||||
protected override async _doObtainBrowser(): Promise<playwright.Browser> {
|
||||
const browserType = playwright[this.browserConfig.browserName];
|
||||
return browserType.launch(this.browserConfig.launchOptions).catch(error => {
|
||||
return browserType.launch({
|
||||
...this.browserConfig.launchOptions,
|
||||
handleSIGINT: false,
|
||||
handleSIGTERM: false,
|
||||
}).catch(error => {
|
||||
if (error.message.includes('Executable doesn\'t exist'))
|
||||
throw new Error(`Browser specified in your config is not installed. Either install it (likely) or change the config.`);
|
||||
throw error;
|
||||
|
|
@ -160,7 +164,12 @@ class PersistentContextFactory implements BrowserContextFactory {
|
|||
const browserType = playwright[this.browserConfig.browserName];
|
||||
for (let i = 0; i < 5; i++) {
|
||||
try {
|
||||
const browserContext = await browserType.launchPersistentContext(userDataDir, { ...this.browserConfig.launchOptions, ...this.browserConfig.contextOptions });
|
||||
const browserContext = await browserType.launchPersistentContext(userDataDir, {
|
||||
...this.browserConfig.launchOptions,
|
||||
...this.browserConfig.contextOptions,
|
||||
handleSIGINT: false,
|
||||
handleSIGTERM: false,
|
||||
});
|
||||
const close = () => this._closeBrowserContext(browserContext, userDataDir);
|
||||
return { browserContext, close };
|
||||
} catch (error: any) {
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue