6ae182696f
When UpdateNodeFromMapRequest and SetNodeTags race on persistNodeToDB, the first caller to run updatePolicyManagerNodes detects the tag change and returns a PolicyChange. The second caller finds no change and falls back to NodeAdded. If UpdateNodeFromMapRequest wins the race, it checked policyChange.IsFull() which is always false for PolicyChange (only sets IncludePolicy and RequiresRuntimePeerComputation). This caused the PolicyChange to be dropped, so affected clients never received PeersRemoved and the stale peer remained in their NetMap indefinitely. Fix: check !policyChange.IsEmpty() instead, which correctly detects any non-trivial policy change including PolicyChange(). This fixes the root cause of TestACLTagPropagation/multiple-tags-partial- removal flaking at ~20% on CI. Updates #3125 |
||
|---|---|---|
| .. | ||
| debug.go | ||
| debug_test.go | ||
| endpoint_test.go | ||
| ephemeral_test.go | ||
| maprequest.go | ||
| maprequest_test.go | ||
| node_store.go | ||
| node_store_test.go | ||
| ssh_check_test.go | ||
| state.go | ||
| tags.go | ||
| test_helpers.go | ||