headscale/hscontrol
Kristoffer Dalby 171fd7a3c5 policy: key autogroup:self invalidation on UserID not User view
invalidateAutogroupSelfCache derived the owning user from
node.User().ID(), dereferencing the User association view. The
NodeStore stores nodes by value with User as a *User pointer, and not
every write path hydrates that association, so a non-tagged node could
reach SetNodes with UserID set but User nil. UserView.ID() then
dereferenced a nil *User and panicked on /machine/map whenever an
autogroup:self policy was active and a node restarted tailscaled.

Group affected nodes by node.TypedUserID(), which reads the UserID
field directly. UserID is the authoritative ownership field for
non-tagged nodes, so this needs no hydrated association and fixes every
.User().ID() site in the function.
2026-05-29 21:42:56 +02:00
..
assets assets: fix logo alignment and error icon centering 2026-04-13 17:23:47 +01:00
capver capver, types: bump to tailscale v1.98, drop LegacyDERPString 2026-05-22 11:22:01 +02:00
db db: backfill zero-time node expiry to NULL 2026-05-27 09:49:05 +02:00
derp all: apply godoc [Name] link conventions across comments 2026-05-19 09:55:22 +02:00
dns all: apply godoc [Name] link conventions across comments 2026-05-19 09:55:22 +02:00
mapper capver, types: bump to tailscale v1.98, drop LegacyDERPString 2026-05-22 11:22:01 +02:00
policy policy: key autogroup:self invalidation on UserID not User view 2026-05-29 21:42:56 +02:00
servertest all: apply godoc [Name] link conventions across comments 2026-05-19 09:55:22 +02:00
state all: apply godoc [Name] link conventions across comments 2026-05-19 09:55:22 +02:00
templates all: apply godoc [Name] link conventions across comments 2026-05-19 09:55:22 +02:00
types capver, types: bump to tailscale v1.98, drop LegacyDERPString 2026-05-22 11:22:01 +02:00
util all: apply godoc [Name] link conventions across comments 2026-05-19 09:55:22 +02:00
app.go all: annotate gosec false positives with rationale 2026-05-19 09:55:22 +02:00
app_test.go app: add security headers middleware 2026-04-17 16:31:49 +01:00
auth.go all: apply godoc [Name] link conventions across comments 2026-05-19 09:55:22 +02:00
auth_tags_test.go all: apply godoc [Name] link conventions across comments 2026-05-19 09:55:22 +02:00
auth_test.go all: apply godoc [Name] link conventions across comments 2026-05-19 09:55:22 +02:00
debug.go all: mechanical lint fixes 2026-05-19 09:55:22 +02:00
grpcv1.go all: apply godoc [Name] link conventions across comments 2026-05-19 09:55:22 +02:00
grpcv1_test.go all: apply godoc [Name] link conventions across comments 2026-05-19 09:55:22 +02:00
handlers.go all: apply godoc [Name] link conventions across comments 2026-05-19 09:55:22 +02:00
handlers_test.go all: apply godoc [Name] link conventions across comments 2026-05-19 09:55:22 +02:00
metrics.go metrics, policy/v2: drop unused scaffolding + nil-error returns 2026-05-19 09:55:22 +02:00
noise.go noise: pin outer RemoteAddr onto tunnel requests 2026-05-20 11:30:41 +02:00
noise_test.go noise: pin outer RemoteAddr onto tunnel requests 2026-05-20 11:30:41 +02:00
oidc.go all: annotate gosec false positives with rationale 2026-05-19 09:55:22 +02:00
oidc_confirm_test.go all: annotate gosec false positives with rationale 2026-05-19 09:55:22 +02:00
oidc_template_test.go oidc: render HTML error pages for browser-facing failures 2026-04-13 17:23:47 +01:00
oidc_test.go oidc: make email verification configurable 2025-12-18 11:42:32 +00:00
platform_config.go all: fix golangci-lint issues (#3064) 2026-02-06 21:45:32 +01:00
poll.go all: apply godoc [Name] link conventions across comments 2026-05-19 09:55:22 +02:00
poll_test.go all: apply godoc [Name] link conventions across comments 2026-05-19 09:55:22 +02:00
realip.go all: apply godoc [Name] link conventions across comments 2026-05-19 09:55:22 +02:00
realip_test.go hscontrol: gate proxy header trust on trusted_proxies 2026-05-18 17:17:55 +02:00
tailsql.go all: annotate gosec false positives with rationale 2026-05-19 09:55:22 +02:00
templates_consistency_test.go Update links to Tailscale documentation 2026-04-18 09:33:41 +02:00